[TuxOnIce-devel] Two issues with TOI for kernel 4.5

[Manuel Krause]

Hi Nigel and hello lists,

I've been using TOI for years now and hope that development will
continue!

With kernel 4.5.2 (thanks for providing the seperate patch on
your download server!) I'm not able to boot my machine. I'm
getting the warning as shown as first entry at
https://github.com/NigelCunningham/tuxonice-kernel/issues/13 --
and then kernel stops and fails to initialize my disks.
On Alfred Chen's Blog
(http://cchalpha.blogspot.de/2016/04/45-vrq-patch-v450469vrq0-released.html?showComment=1460883728320#c2598191117070637004)
post-factum an I have been pinning the problem down to the commit
https://github.com/NigelCunningham/tuxonice-kernel/commit/dc8248c26f7f5ed7bc42f64d3412c24358054069
"Take sb_lock once per cycle, preventing filesystems being
added/removed."

I reverted this, and the subsequent commit before, and the kernel
boots fine again and TOI seems to work normally. Unfortunately I
cannot be glad with this solution:

* On the very first hibernation attempt I get the following warning:
[ 544.082274] WARNING: CPU: 0 PID: 2441 at
kernel/workqueue.c:2416 check_flush_dependency+0x13f/0x150()
[ 544.082277] workqueue: PF_MEMALLOC task 2441(pm-hibernate) is
flushing !WQ_MEM_RECLAIM events_highpri:wq_unbind_fn
-- full trace here: http://paste.opensuse.org/44184299

* When having loop mounted an ext4 formatted file residing on an
ext4 partition, hibernation fails: It stops after saving kernel &
process data, still displaying this by the UI, and not turning
off the machine. The written(?) hibernation image does not get
loaded upon next power-on.

The last kernel I used, 4.3.6, never showed this behaviour.

If you need more information, please, let me know.

Best regards,
Manuel Krause

[Manuel Krause]

Noone answered so far, not even the list's mailer. Now I answer
myself and try to be as lazy... ;-)

I'm citing a new entry of mine at Alfred Chen's Blog regarding
the issues:
--
I've now done the "dumb" job to forward-port my last known
working TOI patch (for kernel 4.3.3) to apply and cleanly compile
on kernel 4.5.2. I didn't bother with cosmetic changes or line
offsets.
No related compile warnings -- and now I can have a loop mounted
ext4 file staying alive again, relevant for anyone who uses
truecrypt or sth. like that.
One thing remains: I get almost the same WARNING like in
http://paste.opensuse.org/44184299 on the first hibernation.

I've uploaded the "ported" patch to
http://workupload.com/file/TFFm8Ka
so someone with knowledge can review and judge the changes, that
make current TOI failing.

BR Manuel Krause
--